Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle #919

Merged
merged 7 commits into from
Jan 4, 2021
Merged

Cycle #919

merged 7 commits into from
Jan 4, 2021

Conversation

Thrameos
Copy link
Contributor

@Thrameos Thrameos commented Jan 4, 2021

This is the usual post release merge that incorporates all the fixes needed to make a release. Items covered here

  • Update the change log and bump the version.
  • There was a problem with the pattern for deciding when to run the fast tests. Due to typo it was not actually running any tests in the CI for architectures other than linux coverage tests. This meant that some undiscovered errors crept in which had to be resolved at release time.
  • Windows adding of missing directories had issues. The URI protocol and the Windows Path specification are not compatible due to differences in Path separators. It was a minor change to convert to a URI first before performing text merging to get the Jar URI specification. There are still 2 extra slashes in the path, but it appears to be harmless. I am not sure why the default path specification is missing the extra slashes as it is supposed to be a root origin path. But apparently the code in Jar does not require it.
  • A version of Jedi is having issues. It is possible that a bad behavior in JPype is triggering it, but it will take time to resolve which I am short on right now, so I just disabled the problematic tests. We should make an issue to investigate it at a later point.

@marscher I deleted most of the old branches used in the release process. I could tag on release rather than releases/vXXX if you would prefer though it is much safer to tag and release to releases/vXXX because I can be sure that I am at the right point on azure and when performing the tagging. Working with branches is a easier than working with tags when resolving release issues so I would prefer to keep the current procedure. We can delete the branches after the release clears if you feel the extra branches are an issue. Just update the release procedure under doc/release.rst so that next release is executed differently. At minimum we still need master for incoming PRs, release which has the current release head (which is the only one that has non _dev version tags, and of course cycle which is used to bump the master so that we don't ever get confusion between master and releases.

@Thrameos Thrameos requested a review from marscher January 4, 2021 02:26
@Thrameos Thrameos self-assigned this Jan 4, 2021
@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #919 (dd56b9e) into master (3b13848) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files         112      112           
  Lines       10011    10011           
  Branches     4045     4045           
=======================================
  Hits         8786     8786           
  Misses        622      622           
  Partials      603      603           
Impacted Files Coverage Δ
native/python/pyjp_module.cpp 83.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd515b...dd56b9e. Read the comment docs.

@marscher
Copy link
Member

marscher commented Jan 4, 2021

I'm really sorry for this stupid typo mistake in the CI. I hope it didn't cause too much trouble. Luckily you executed most tests locally during development. Thank you very much for this quick micro release.

@marscher marscher merged commit f4d59ee into master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants